Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IDEA] Transmog 2.0 - Unlimited items collection #43

Open
Yehonal opened this issue Dec 29, 2020 · 13 comments · May be fixed by #166
Open

[IDEA] Transmog 2.0 - Unlimited items collection #43

Yehonal opened this issue Dec 29, 2020 · 13 comments · May be fixed by #166

Comments

@Yehonal
Copy link
Member

Yehonal commented Dec 29, 2020

I write this idea here as a reminder for the future.

The idea is to collect information about ALL the items collected during the game and use the subset of those transmogrifable items within the transmog NPC thus having unlimited transmog possibility (such as in retail). It also means that you don't have to keep the item in your bags/bank then.

Requirements:

  • CORE change: historical data of all items collected, and the quantity (to integrate within the core), we can extend/reuse the current system that stores the deleted items in order to use the information we have there.

  • Module Change: the possibility for the transmog NPC to search within the list of the items you have and also of the items you deleted, and use the transmogrifable items (such as the collection feature in retail) with the following limitation: Binds on Equip items that have not been equipped, can't be transmogrified. This should be a configurable option with an table to activate/deactivate this feature per player. The configuration should support the following options: 1. deactivated, 2. enabled for all, 3. enabled for specific characters (using a table)


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@LukasVolgger
Copy link
Member

Great idea! +1

@yuanf225
Copy link

yuanf225 commented Dec 3, 2021

Is anyone interested in developing this?

@yuanf225
Copy link

https://ezwow.org/topic/131942
This is a plug-in shared by someone on the model-changing.net channel today, corresponding to the legion transformation function
image
image
See if it helps to develop a new transmog module

@ZhengPeiRu21
Copy link
Contributor

Has anyone start on developing this yet? If no, I will start the work. This will be my first AC module so I could be slow but will figure it out! I have already create some very basic AddOn to track collected items and show tooltip for "New Appearance" if equipment is not yet collect.

@Yehonal
Copy link
Member Author

Yehonal commented Feb 6, 2022

Hi! no one started it yet, however, we should provide an addon but also a way to use this feature with a NPC (when the addon is not available). I can guide you in it, you can contact me on discord if you like: Yehonal#4265

@ZhengPeiRu21
Copy link
Contributor

I have created PR that is implementing this feature. Please see: #72

@Helias
Copy link
Member

Helias commented Jun 24, 2022

Can we close this considering #72 ?

@Yehonal
Copy link
Member Author

Yehonal commented Jun 24, 2022 via email

@Nyeriah
Copy link
Member

Nyeriah commented Jun 24, 2022

Pagination can be done with gossips but I think it'd really be so much better if we instead took the route taken in Rochete's transmog vendor.

@Yehonal
Copy link
Member Author

Yehonal commented Oct 11, 2022 via email

@ZhengPeiRu21
Copy link
Contributor

Searchbox + vendor views is the solution imho

On Sat, 25 Jun 2022, 00:49 Skjalf, @.> wrote: Pagination can be done with gossips but I think it'd really be so much better if we instead took the route taken in Rochete's transmog vendor. — Reply to this email directly, view it on GitHub <#43 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABD5FHZI2MBCOAVOUDJPHTVQY3PTANCNFSM4VNLUJ4Q . You are receiving this because you authored the thread.Message ID: @.>

I implemented a Searchbox in #93. I do not think vendor view is possible with the collection system because there is no way to populate vendor different per player (this might be possible with core changes, but could not be done right now as a module.) There may be some way I do not know about, though!

@Yehonal
Copy link
Member Author

Yehonal commented Oct 13, 2022

Searchbox + vendor views is the solution imho

On Sat, 25 Jun 2022, 00:49 Skjalf, @.> wrote: Pagination can be done with gossips but I think it'd really be so much better if we instead took the route taken in Rochete's transmog vendor. — Reply to this email directly, view it on GitHub <#43 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABD5FHZI2MBCOAVOUDJPHTVQY3PTANCNFSM4VNLUJ4Q . You are receiving this because you authored the thread.Message ID: _@**.**_>

I implemented a Searchbox in #93. I do not think vendor view is possible with the collection system because there is no way to populate vendor different per player (this might be possible with core changes, but could not be done right now as a module.) There may be some way I do not know about, though!

This is how I handled it 3 years ago to implement an unlimited bank. Reading items from a table and then showing them in a vendor view by using this trick: https://github.com/AzerothShard/azerothshard-core/blob/7f09d76a35794ae9302d6e421493cbe5ed516092/modules/DonationsVendor/src/scripts/ItemToSell.cpp#L70

In a nutshell, I populate the opcode SMSG_LIST_INVENTORY with data by faking a vendor, then here: https://github.com/AzerothShard/azerothshard-core/blob/development/modules/DonationsVendor/src/scripts/DonationsVendor.cpp#L338 I handle what should happen during the buying.

Let me know if you need any further clarifications

note for my self: I should import those modules sooner or later, I spent a life on them

@ZhengPeiRu21
Copy link
Contributor

[…]

Thank you so much to share, this is a very interesting trick! When I am able to find the time I will give it a try to implement it this way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants