feat: add PLAYER_EVENT_ON_QUEST_REWARD_ITEM, add PLAYER_EVENT_ON_CREATE_ITEM, add PLAYER_EVENT_ON_STORE_NEW_ITEM #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-o-b-o-t-o
requested changes
Jan 25, 2023
There was a problem hiding this comment.
Thanks for the PR!
Could you please do the following:
- Add a description of your changes to the
READMEfile (example) - Add a line to
RegisterPlayerEvent's doc comment (basically the lines you added toHooks.hbut as comment lines, example) - Take a look at my code suggestions, they're just line breaks so not very important but let's try to keep things consistent if possible 😄
Co-authored-by: Axel Cocat <ax.cocat@gmail.com>
Co-authored-by: Axel Cocat <ax.cocat@gmail.com>
Co-authored-by: Axel Cocat <ax.cocat@gmail.com>
update README.md under the pulling rule.
updated README_CN.md and GLOBALMETHODS_H under the pulling rule.
r-o-b-o-t-o
approved these changes
Jan 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add PLAYER_EVENT_ON_QUEST_REWARD_ITEM
add PLAYER_EVENT_ON_CREATE_ITEM
add PLAYER_EVENT_ON_STORE_NEW_ITEM