-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core/func): GetSpeedRate + SetSpeedRate + ifdefs #155
Conversation
Fixxed: SetSpeed and GetSpeed Function Added: SetSpeedRate and GetSpeedRate Removed: Unnecessary Ifdef's
Thanks for the PR! |
Thanks for your PR! It looks like you're not using |
Remove forced as its not used in SetSpeedRate
@svenbledt build is failing. Want to adjust? |
i sadly dont know why build is failing :D worked fine on my end :o |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI should work again now.
Sorry I forgot to mention this earlier, could you please add a change to the README file to document your additions? See an example here
Co-authored-by: Axel Cocat <ax.cocat@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks mate
Fixxed: SetSpeed and GetSpeed Function
Added: SetSpeedRate and GetSpeedRate
Removed: Unnecessary Ifdef's
Foe recognized on the azerothcore mod-eluna repo that the SetSpeed function is using the wrong SetSpeedRate member of unit.
This PR changes that and seperates the functions from each other.
Also we decided to remove the ifdefs that are not needed as the module is only for azerothcore and not for Trinty or Mangos.
You can test this PR by using the functions in a script and check the impact ;)
Thanks for your time!