fix(core/func): GetSpeedRate + SetSpeedRate + ifdefs #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixxed: SetSpeed and GetSpeed Function Added: SetSpeedRate and GetSpeedRate Removed: Unnecessary Ifdef's
|
Thanks for the PR! |
|
Thanks for your PR! It looks like you're not using |
Remove forced as its not used in SetSpeedRate
|
@svenbledt build is failing. Want to adjust? |
i sadly dont know why build is failing :D worked fine on my end :o |
r-o-b-o-t-o
requested changes
Oct 14, 2023
There was a problem hiding this comment.
The CI should work again now.
Sorry I forgot to mention this earlier, could you please add a change to the README file to document your additions? See an example here
Co-authored-by: Axel Cocat <ax.cocat@gmail.com>
r-o-b-o-t-o
reviewed
Oct 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixxed: SetSpeed and GetSpeed Function
Added: SetSpeedRate and GetSpeedRate
Removed: Unnecessary Ifdef's
Foe recognized on the azerothcore mod-eluna repo that the SetSpeed function is using the wrong SetSpeedRate member of unit.
This PR changes that and seperates the functions from each other.
Also we decided to remove the ifdefs that are not needed as the module is only for azerothcore and not for Trinty or Mangos.
You can test this PR by using the functions in a script and check the impact ;)
Thanks for your time!