-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Method to Player: SetGlyph #152
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR! Please have a look at my comment.
Co-authored-by: Axel Cocat <ax.cocat@gmail.com>
Co-authored-by: Axel Cocat <ax.cocat@gmail.com>
Co-authored-by: Axel Cocat <ax.cocat@gmail.com>
Co-authored-by: Axel Cocat <ax.cocat@gmail.com>
Co-authored-by: Axel Cocat <ax.cocat@gmail.com>
Co-authored-by: Axel Cocat <ax.cocat@gmail.com>
src/LuaEngine/PlayerMethods.h
Outdated
uint32 slotIndex = Eluna::CHECKVAL<uint32>(L, 3); | ||
|
||
player->SetGlyph(slotIndex, glyphId, !player->GetSession()->PlayerLoading()); | ||
#if (!defined(TBC) && !defined(CLASSIC)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The #if isn't required, since mod-eluna is only for wotlk as inAC 3.3.5.
I'm sure Eluna master would appreciate the expansion dependencies, but we haven't added any to our customisations, so I don't think we should start now.
wtb |
can update? I am not know how push the pr PlayerMethods.h LuaFunctions.cpp player
|
Adds a Method to the Lua Player Object which allows to set Glyphs for the current TalentGroup/Spec
Compiles: yes
Tested: yes
Test Instructions/example Usage: