Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Unit:GetAttackers #116

Merged
merged 2 commits into from
Apr 4, 2023
Merged

feat: add Unit:GetAttackers #116

merged 2 commits into from
Apr 4, 2023

Conversation

r-o-b-o-t-o
Copy link
Member

No description provided.

@r-o-b-o-t-o r-o-b-o-t-o merged commit 8a85df8 into master Apr 4, 2023
@r-o-b-o-t-o r-o-b-o-t-o deleted the feat/get-attackers branch April 4, 2023 19:17
Tony931023 added a commit to ShadowNet-Cuba/mod-eluna that referenced this pull request Apr 5, 2023
@Tony931023 @r-o-b-o-t-o
Update (#1)
c9435b9 
* fix(ci): exclude date.js from doc PR git status (azerothcore#108)

* feat: add async queries (azerothcore#113)

* fix(ci): exclude date.js from doc PR git status

* feat: replace getLevel with GetLevel (azerothcore#115)

* fix: GetItemLink crash (azerothcore#114)

* feat: add Unit:GetAttackers (azerothcore#116)

* feat: add Unit:GetThreatList (azerothcore#117)

---------

Co-authored-by: Axel Cocat <ax.cocat@gmail.com>
@GoMateoGo
Copy link

If it is an event: PLAYER_ EVENT_ ON_ DAMAGE_ TAKEN

Various attackers can be obtained through attacker ->gettype()

This is one of my thoughts

Because I can't imagine where to use the global method. GameObject and Creature both have ON_ DAMAGE_ TAKEN

@r-o-b-o-t-o
Copy link
Member Author

Sorry, I'm not sure I understand what you want.
If you have a question or a feature request, feel free to open a separate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@55Honey 55Honey 55Honey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@r-o-b-o-t-o @GoMateoGo @55Honey