Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #35

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Update README.md #35

merged 1 commit into from
Mar 20, 2024

Conversation

Kaev
Copy link
Member

@Kaev Kaev commented Mar 20, 2024

Changes Proposed:

  • Added acidmanifesto credits to the readme

Issues Addressed:

  • Closes ongoing discussions about the original author of it

Added acidmanifesto credits to the readme
@FrancescoBorzi FrancescoBorzi merged commit 359f63c into azerothcore:master Mar 20, 2024
1 check passed
@pangolp
Copy link
Contributor

pangolp commented Mar 20, 2024

This information is not 100% correct. If we're going to edit the README, that's fine with me. But I've been trying to make this work for 2 years, creating the hooks, testing the code, making changes to it and I didn't get into the credits, to give a little to everyone. That's why I didn't name anyone in particular. I don't think it's fair to do so. We'll have to name them all. By seeing the commits and pull requests, you will be able to deduce who wanted this to work and make it a reality today.

@pangolp
Copy link
Contributor

pangolp commented Mar 20, 2024

I would like to know in what context this discussion was generated. Because now the only thing missing is for them to believe that I don't want to recognize certain people. I have updated more than 100 modules, and I did not give myself credit, not even in a single one of them. Now I have the doubt, why it was necessary to specifically name a person who participated, as several of us participated, but she was not the only one and that the code is not 100% that seen in the pull request that is mentioned.

@FrancescoBorzi
Copy link
Contributor

@pangolp this was generated by Acidmanifesto requesting to get credits for his prior work.

All contributors, including yourself, are automatically listed in https://github.com/azerothcore/mod-aoe-loot/graphs/contributors

the problem is that because of the way the code was added, Acidmanifesto did not get to that page, that is why we are making an exception and mentioning him in the README. For the other contributors, this is not needed as they regularly appear in the Contributors list that GitHub nicely generates for us automatically, including statistics about lines of code etc..

@pangolp
Copy link
Contributor

pangolp commented Mar 20, 2024

@pangolp this was generated by Acidmanifesto requesting to get credits for his prior work.

All contributors, including yourself, are automatically listed in https://github.com/azerothcore/mod-aoe-loot/graphs/contributors

the problem is that because of the way the code was added, Acidmanifesto did not get to that page, that is why we are making an exception and mentioning him in the README. For the other contributors, this is not needed as they regularly appear in the Contributors list that GitHub nicely generates for us automatically, including statistics about lines of code etc..

Good. I understand. But I read the original message and it seemed that I didn't want to give credits or something like that and I say... the only thing missing is that you believe that I am stealing other people's ideas at this point in my life... obviously, I misunderstood the pull request, but it sounded really strange when I read it. Thanks for the clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants