Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Update #2

Closed
wants to merge 4 commits into from
Closed

WIP Update #2

wants to merge 4 commits into from

Conversation

acidmanifesto
Copy link
Contributor

No description provided.

Comment on lines +63 to +78
class AoeLootAnnounce : public PlayerScript
{
public:
AoeLootAnnounce() : PlayerScript("AoeLootAnnounce") {}
void OnLogin(Player* Player) override
{
// Announce Module
if (AOELootEnable)
{
if (AOELootAnnounceModule)
{
ChatHandler(Player->GetSession()).SendSysMessage("This server is running the |cff4CFF00AOE Loot Azerothcore Custom |rmodule.");
}
}
}
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why need this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was to test that i understood using the hooks right really. It did work and can be removed if you want. Right now i am dealing with a internet outage so my response will be slow.

src/AoeLoot.cpp Outdated Show resolved Hide resolved
src/AoeLoot.cpp Outdated Show resolved Hide resolved
acidmanifesto and others added 2 commits October 14, 2021 16:25
Co-authored-by: Kargatum <dowlandtop@yandex.com>
Co-authored-by: Kargatum <dowlandtop@yandex.com>
src/AoeLoot.cpp Outdated Show resolved Hide resolved
@acidmanifesto
Copy link
Contributor Author

Be advise we are still working modulating this feature. It currently is not working until we get the hooks implemented.

@pangolp
Copy link
Contributor

pangolp commented Oct 16, 2021

Be advise we are still working modulating this feature. It currently is not working until we get the hooks implemented.

I was only trying to help, I think the idea is very good.

@acidmanifesto
Copy link
Contributor Author

Be advise we are still working modulating this feature. It currently is not working until we get the hooks implemented.

I was only trying to help, I think the idea is very good.

Oh i agree and will drop it in when im free. Been having people message me that its not working not realizing its wip for az

@pangolp
Copy link
Contributor

pangolp commented Oct 16, 2021

Those kind of people you have to ignore them, I just entered the repository because I got a notification. Maybe if you update the README.md, you can indicate that it is still under development. I think the idea is great. I will try to test it later.

@Helias
Copy link
Member

Helias commented Oct 23, 2021

build failin, please fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants