Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DB/RP): Add missing RP for Recover the Cargo! #19611

Merged
merged 5 commits into from
Aug 25, 2024

Conversation

kamenitxan
Copy link
Contributor

@kamenitxan kamenitxan commented Aug 13, 2024

fix(DB/Gossip): adds missing gossip for Recover the Cargo! author ZenoX92 from TrinityCore

Changes Proposed:

This PR proposes changes to:

  • Core (units, players, creatures, game systems).
  • Scripts (bosses, spell scripts, creature scripts).
  • Database (SAI, creatures, etc).

Issues Addressed:

SOURCE:

The changes have been validated through:

  • Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
  • Sniffs (remember to share them with the open source community!)
  • Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
  • The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

  • Tested in-game by the author.
  • Tested in-game by other community members/someone else other than the author/has been live on production servers.
  • This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

  • This pull request can be tested by following the reproduction steps provided in the linked issue
  • This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

Known Issues and TODO List:

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

fix(DB/Gossip): adds missing gossip for Recover the Cargo!
author ZenoX92 from TrinityCore
@github-actions github-actions bot added the DB related to the SQL database label Aug 13, 2024
@kamenitxan
Copy link
Contributor Author

Gossip for Repaired Diving Gear fixed. I have changed action type from 85 SELF_CAST to 134 INVOKER_CAST

@sudlud
Copy link
Member

sudlud commented Aug 18, 2024

Can you please add a commit referencing the original author of the cherry pick (so git will show 2 authors for this PR)

@Grimdhex
Copy link
Contributor

Incorrect title standard, can you fix it ? fix(DB/Gossip): adds missing gossip for Recover the Cargo!

@kamenitxan kamenitxan changed the title Add missing RP for Recover the Cargo! fix(DB/SAI): Add missing RP for Recover the Cargo! Aug 19, 2024
@kamenitxan kamenitxan changed the title fix(DB/SAI): Add missing RP for Recover the Cargo! fix(DB/RP): Add missing RP for Recover the Cargo! Aug 19, 2024
@kamenitxan
Copy link
Contributor Author

Hi, both issues should be fixed now.

@alecsci
Copy link
Member

alecsci commented Aug 22, 2024

Tested ✅

  1. RP event works.
    image

  2. I can get a repaired diving gear every time I delete it or it expires.

@alecsci alecsci added Tested This PR has been tested and is working. Ready to be Reviewed and removed Waiting to be Tested labels Aug 22, 2024
@sudlud sudlud merged commit 3463ff7 into azerothcore:master Aug 25, 2024
29 checks passed
@kamenitxan kamenitxan deleted the gossip_8934 branch August 26, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DB related to the SQL database Tested This PR has been tested and is working. To Be Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants