-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(DB/RP): Add missing RP for Recover the Cargo! #19611
Conversation
fix(DB/Gossip): adds missing gossip for Recover the Cargo! author ZenoX92 from TrinityCore
Gossip for Repaired Diving Gear fixed. I have changed action type from 85 SELF_CAST to 134 INVOKER_CAST |
Can you please add a commit referencing the original author of the cherry pick (so git will show 2 authors for this PR) |
Incorrect title standard, can you fix it ? fix(DB/Gossip): adds missing gossip for Recover the Cargo! |
Author ZenoX92 from TrinityCore
Hi, both issues should be fixed now. |
Tested ✅
|
fix(DB/Gossip): adds missing gossip for Recover the Cargo! author ZenoX92 from TrinityCore
Changes Proposed:
This PR proposes changes to:
Issues Addressed:
SOURCE:
The changes have been validated through:
Tests Performed:
This PR has been:
How to Test the Changes:
Known Issues and TODO List:
How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].
You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR
REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).
For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.