Upgrade boto to boto3 in deployment scripts #1377
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Upgrades
boto
, used for our deployment scripts, withboto3
version1.15.9
, now at parity withboto3
used elsewhere in app.Notes
boto
outside of deployment scripts for theapp
vm, here, used to add the instance IP toALLOWED_HOSTS
for the ELBs. There's currently an open issue to add a comparable method toboto3
and until then the preferred solutions seem to continue to useboto.utils
or a 3rd party package, ec2-metadata. There is a describe_instances method inboto3
that looks like we can get the public IP address from, but I'm not sure which instance we should be filtering for here that would be comparable toget_instance_metadata
in production. Ultimately this is a pretty narrow use case forboto
and it felt worth keeping this one utility in since it's not part of our deployment.Testing Instructions
majorkirby.MKUnresolvableInputError
when running the commands outside the context of aGlobalConfigNode
. To test we will need to temporarily launch a web stack to confirm no issues and then delete once successful.Checklist
Connects #1116