This repository has been archived by the owner on Aug 31, 2018. It is now read-only.
test: add more tests for workers #121
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Worker threads need an event loop without active libuv handles in order to shut down. One source of handles that was previously not accounted for were delayed V8 tasks; these create timers that would be standing in the way of clearing the event loop. To solve this, keep track of the scheduled tasks in a list and close their timer handles before the corresponding isolate/loop is removed from the platform. It is not clear from the V8 documentation what the expectation is with respect to pending background tasks at the end of the isolate lifetime; however, an alternative approach of executing these scheduled tasks when flushing them led to an infinite loop of tasks scheduling each other; so it seems safe to assume that the behaviour implemented in this patch is at least acceptable.
Taken from petkaantonov/io.js@ea143f7 and modified to fit current linter rules and coding style. Also, some new tests were added to the suite.
Qard
reviewed
Oct 26, 2017
|
|
||
| require('../common'); | ||
|
|
||
| require('./index.js').runTestsInsideWorker([ |
There was a problem hiding this comment.
Might be better, if possible, to grab all files from a readdir that match the test-${subsystem} prefix for each of these and explicitly blacklist specific files known to not work. That way new tests will run in worker tests too, by default.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[the first commit is temporary, from #120, to make tests pass]
Taken from petkaantonov/io.js@ea143f7
and modified to fit current linter rules and coding style.
Also, some new tests were added to the suite.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test/worker