-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Images are saved as .htm files #22
Comments
I could maybe try fixing this on the proxy server by setting the content-disposition 'filename' header, but then even if it works you'd be downloading a potentially very lossy .webp file. We should allow passthrough to the original image for this case, but idk how to distinguish, there needs to be something in the request headers... https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Disposition Update*: Tried setting the Content-Disposition headers they do not seem to help very much on Firefox for Android. Does seem to help preserve the original filename on Firefox for desktop where it was already getting the .webp file extension right... |
same problem: proposed solution:
url-encoding the original url is not necessary the original url can be simply appended to the proxy prefix move the parameters l=20 and bw=0 to the suffix optional parameters can be prepended to the path, like
why not do this client-side? |
old format /?url=https%3A%2F%2Fhost%2Fpath%2Ffile.jpg&jpeg=0&bw=0&l=50 new format /https/host/path/file.jpg.c50.webp solve issue ayastreb#22 new format must be supported by server (bandwidth-hero-proxy)
Thanks for this great addon.
I have only found 1 minor issue so far:
All images get saved as myherokuservername.htm and not imagename.jpg or whatever.
I can simply rename them afterwards, but I'm curious if I'm alone with this issue, or is it a known side-efffect?
I have only tested this behaviour in Firefox Android (latest stable) as I don't have access to a computer at the moment.
Thanks
The text was updated successfully, but these errors were encountered: