Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add docs #947

Merged
merged 8 commits into from
Dec 13, 2023
Merged

Add docs #947

merged 8 commits into from
Dec 13, 2023

Conversation

hamelsmu
Copy link
Collaborator

Three things I added docs about:

  1. Confusion that can happen around tokenization
  2. How to add special tokens
  3. Clarification of how to correctly apply the llama format

@NanoCode012
Copy link
Collaborator

NanoCode012 commented Dec 13, 2023 •
edited
Loading

Please rebase. I think you don't have latest readme changes.

Ex: Mistral MOE gone from readme, info about latest eval_per_epoch missing

@hamelsmu
Copy link
Collaborator Author

@NanoCode012 Thanks. Should be good now

@hamelsmu
Copy link
Collaborator Author

hamelsmu commented Dec 13, 2023 •
edited
Loading

Ahh nevermind I thought it was just the linter that was changing the table but still off Fixed it

winglian
winglian reviewed Dec 13, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@hamelsmu @winglian
Update README.md
daa3c6e 
Co-authored-by: Wing Lian <wing.lian@gmail.com>
winglian
winglian approved these changes Dec 13, 2023
View reviewed changes
Copy link
Collaborator

@winglian winglian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@hamelsmu hamelsmu merged commit 712fd27 into main Dec 13, 2023
@winglian winglian deleted the mor-docs branch January 23, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winglian winglian winglian approved these changes

@NanoCode012 NanoCode012 Awaiting requested review from NanoCode012

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hamelsmu @NanoCode012 @winglian