Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't train if eval split is too small #873

Merged
merged 5 commits into from
Nov 16, 2023
Merged

don't train if eval split is too small #873

merged 5 commits into from
Nov 16, 2023

Conversation

winglian
Copy link
Collaborator

No description provided.

@winglian winglian changed the title allow zero len dataset don't report len of 1 if it's actually zero Nov 16, 2023
@winglian winglian changed the title don't report len of 1 if it's actually zero don't train if eval split is too small Nov 16, 2023
@winglian winglian merged commit 797f3dd into main Nov 16, 2023
4 checks passed
@winglian winglian deleted the min-steps-fix branch November 16, 2023 16:35
@winglian
Copy link
Collaborator Author

resolves #871

mkeoliya pushed a commit to mkeoliya/axolotl that referenced this pull request Dec 15, 2023
* allow zero len dataset

* better handling and warning of small eval splits

* raise error if eval split is too small

* don't mess with calculating total num steps in distributed context

* fix eval_sample_packing training args logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant