Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin hf transformers and accelerate to latest release, don't reinstall pytorch #859

Closed
wants to merge 7 commits into from

Conversation

winglian
Copy link
Collaborator

No description provided.

@NanoCode012
Copy link
Collaborator

Can we remove the pip3 install -U git+https://github.com/huggingface/peft.git from Readme then since it's in requirements?

Secondly, setup.py should remove the torch logic also?

@winglian
Copy link
Collaborator Author

Can we remove the pip3 install -U git+https://github.com/huggingface/peft.git from Readme then since it's in requirements?

Secondly, setup.py should remove the torch logic also?

updated. thanks!

@casper-hansen
Copy link
Collaborator

I think this is a good change. What do you think about pinning transformers to a specific release? Then you can upgrade on a per-need basis. This should limit breakage!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants