-
-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow overriding of model_config parameters from the YML #853
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice clean PR! I think you'd want to add this to the docs as well.
Should we deprecate the current rope configs and move them here also?
1defaf2
to
13483fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more point to update would be the config_validate for backward compatible..
which rope configs are you referring to? |
Ah, I meant |
…cloud#853) * allow overriding of model_config parameters from the YML * remove old logging, update readme * move the updating of model config to the load_model_config function * add warning for deprecated rope_scaling in the root of the YML config
This should allow users to update values in the model config without having to edit the JSON.
for example for the attention_dropout for #672