Feat: Warns to add to modules_to_save when adding tokens or switching special_tokens #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winglian
reviewed
Oct 26, 2023
NanoCode012
force-pushed
the
fix/add_modules_to_save
branch
from
85acdce
to
6ceeb61
Compare
|
The code now errors when the config is incorrect in these adapter training cases:
Breaking change: This means that all training configs without proper modules_to_save won't work now, which should be as intended as they may have been incorrect. |
NanoCode012
changed the title
NanoCode012
force-pushed
the
fix/add_modules_to_save
branch
from
6ceeb61
to
c767325
Compare
winglian
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.