-
-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add support for upstream FA2 #626
Conversation
Maybe add |
there is some falcon patching that also already happens here https://github.com/OpenAccess-AI-Collective/axolotl/blob/f3d939016a6ec681be40e83c6a57c682cb60e2b1/src/axolotl/utils/models.py#L117-L127 |
Does sample packing work for falcon? I'll consolidate the check for falcon derived model. |
no, it's basic flash attention support only |
Tested with CUDA_VISIBLE_DEVICES=0 accelerate launch -m axolotl.cli.train examples/openllama-3b/lora.yml using sample_packing off. With main 5e5296a, it gives: [2023-09-26 13:00:15,139] [INFO] [axolotl.train.train:84] [PID:751] [RANK:0] Pre-saving adapter config to ./lora-out
[2023-09-26 13:00:15,141] [INFO] [axolotl.train.train:108] [PID:751] [RANK:0] Starting trainer...
{'loss': 1.3152, 'learning_rate': 1e-05, 'epoch': 0.0} With sample_packing on, it runs as usual. main has no issues here either. |
* Feat: Add support for upstream FA2 * chore: add is_falcon_derived_model: true to examples * chore: add config to readme for documentation * feat: add extra model types * fix: remove old falcon flash patch * chore: pin transformers and accelerate
Untested!
Only works for
TODO:
Ref Upstream PR: https://github.com/huggingface/transformers/pull/25598/files