Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(data): Allow loading local csv and text #594

Merged
merged 2 commits into from
Sep 17, 2023
Merged

Feat(data): Allow loading local csv and text #594

merged 2 commits into from
Sep 17, 2023

Conversation

NanoCode012
Copy link
Collaborator

We forgot these two.

@NanoCode012
Copy link
Collaborator Author

NanoCode012 commented Sep 17, 2023 •
edited
Loading

Seems like we don't even use ds_type from the cfg in the code? We seem to load it from the file extension

    ds_type: # Optional[str] (json|arrow|parquet|text|csv) defines the datatype when path is a file

Should this be removed?

@winglian
Copy link
Collaborator

See line 180image

@NanoCode012
Copy link
Collaborator Author

NanoCode012 commented Sep 17, 2023 •
edited
Loading

Ah I see. That would mean this PR changes might not be necessary. Only Readme is new.

@winglian winglian merged commit 00dce35 into axolotl-ai-cloud:main Sep 17, 2023
4 checks passed
mkeoliya pushed a commit to mkeoliya/axolotl that referenced this pull request Dec 15, 2023
@NanoCode012
Feat(data): Allow loading local csv and text (axolotl-ai-cloud#594)
9bfe565 
* Feat(data): Allow loading local csv and text

* chore: update readme for loading data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winglian winglian winglian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NanoCode012 @winglian