Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

let hf trainer handle torch compile #516

Merged
merged 5 commits into from
Sep 13, 2023
Merged

let hf trainer handle torch compile #516

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1eafdea
let hf trainer handle torch compile
winglian Aug 31, 2023
72e340a
remove torch compile checks, include option for backend
winglian Aug 31, 2023
f899427
Merge branch 'main' into torch-compile
winglian Aug 31, 2023
a0081c5
suppress torch errors to get further
tmm1 Sep 3, 2023
2362a54
require min torch version of 2.1.0 for torch compile to work
winglian Sep 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/axolotl/train.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,10 +80,6 @@ def train(

model.config.use_cache = False

if torch.__version__ >= "2" and sys.platform != "win32":
tmm1 marked this conversation as resolved.
Show resolved Hide resolved
LOG.info("Compiling torch model")
model = torch.compile(model)

# go ahead and presave, so we have the adapter config available to inspect
if peft_config:
LOG.info(f"Pre-saving adapter config to {cfg.output_dir}")
Expand Down
3 changes: 3 additions & 0 deletions src/axolotl/utils/trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -579,6 +579,9 @@ def setup_trainer(cfg, train_dataset, eval_dataset, model, tokenizer, total_num_
if cfg.bench_dataset:
training_arguments_kwargs["bench_dataset"] = cfg.bench_dataset

if torch.__version__ >= "2" and sys.platform != "win32":
training_arguments_kwargs["torch_compile"] = True
winglian marked this conversation as resolved.
Show resolved Hide resolved

training_args = AxolotlTrainingArguments( # pylint: disable=unexpected-keyword-arg
max_steps=total_num_steps if cfg.max_steps else -1,
max_seq_length=cfg.sequence_len,
Expand Down