Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setting correct repo id when pushing dataset to hub #1657

Merged
merged 4 commits into from
Aug 5, 2024

Conversation

chrislee973
Copy link
Contributor

@chrislee973 chrislee973 commented May 25, 2024

Description

In the dataset preprocessing step, pass the dataset hash as the config_name parameter in push_to_hub if push_dataset_to_hub is set. The config_name parameter is used for handling different versions/configurations of a dataset, which fits our case here.

Motivation and Context

The push_dataset_to_hub config setting takes a value in the form <user>/<dataset_name>, but the previous implementation was pushing to hub with the id f"{cfg.push_dataset_to_hub}/{ds_hash}", which was causing an error because <user>/<dataset_name>/<ds_hash> is an invalid hf repo id.

How has this been tested?

  • With push_dataset_to_hub set, ran the dataset preprocessing step several times with different dataset settings each time.
  • Confirmed that this successfully pushed different variations of the dataset to hf hub (screenshot)
  • On subequent dataset preprocessing runs with the same settings, confirmed that we successfully pulled down the variation of that dataset from hf hub.
    image

Types of changes

  • Dataset preprocessing step

@winglian
Copy link
Collaborator

Thanks @chrislee973 The original intention was to "cache" the pre-processed dataset to its own dataset, but this is much better. Were you able to verify that it loads the subdirectory only when there are 2 or more datasets uploaded and you remove the local dataset cache ?

Copy link
Collaborator

@winglian winglian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chrislee973 Thanks for the PR. Just tested. good to go!

@winglian winglian merged commit 7402eb9 into axolotl-ai-cloud:main Aug 5, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants