Fix setting correct repo id when pushing dataset to hub #1657
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the dataset preprocessing step, pass the dataset hash as the config_name parameter in push_to_hub if
push_dataset_to_hub
is set. Theconfig_name
parameter is used for handling different versions/configurations of a dataset, which fits our case here.Motivation and Context
The
push_dataset_to_hub
config setting takes a value in the form<user>/<dataset_name>
, but the previous implementation was pushing to hub with the idf"{cfg.push_dataset_to_hub}/{ds_hash}"
, which was causing an error because<user>/<dataset_name>/<ds_hash>
is an invalid hf repo id.How has this been tested?
push_dataset_to_hub
set, ran the dataset preprocessing step several times with different dataset settings each time.Types of changes