Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SaveAxolotlConfigtoWandBCallback to use artifact instead of save #1483

Merged
merged 3 commits into from
Apr 9, 2024
Merged

Update SaveAxolotlConfigtoWandBCallback to use artifact instead of save #1483

merged 3 commits into from
Apr 9, 2024

Conversation

tcapelle
Copy link
Contributor

@tcapelle tcapelle commented Apr 5, 2024 •
edited
Loading

Removing the use wandb.save in favor of wandb.artifact

@winglian
Copy link
Collaborator

winglian commented Apr 7, 2024

@tcapelle So we had originally implemented it this way here: #716

but, people (I agree too) found it annoying having to find it in the artifacts so it was changed to it's current state here. #1014

Let's discuss what is sane. perhaps some sort of configurability for it?

@winglian winglian merged commit 5ed2939 into axolotl-ai-cloud:main Apr 9, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winglian winglian winglian left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tcapelle @winglian