Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

additional logging to get maximum token length of a sequence in the dataset #1066

Merged
merged 2 commits into from
Jan 10, 2024

Conversation

winglian
Copy link
Collaborator

@winglian winglian commented Jan 8, 2024

No description provided.

max_input_len = np.max(get_dataset_lengths(train_dataset))
LOG.debug(f"max_input_len: {max_input_len}", main_process_only=True)

train_dataset = train_dataset.filter(drop_long, num_proc=cfg.dataset_processes)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to count how many samples are dropped?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, let's slate that for another feature/PR. This was just shuffling around the order.

@winglian winglian merged commit 2f2582e into main Jan 10, 2024
6 checks passed
@winglian winglian deleted the log-token-len branch January 10, 2024 05:49
@winglian winglian mentioned this pull request Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants