Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use recommended setting for use_reentrant w gradient checkpointing #1021

Merged
merged 2 commits into from
Jan 2, 2024

Conversation

winglian
Copy link
Collaborator

fixes

packages/torch/utils/checkpoint.py:429: UserWarning: torch.utils.checkpoint: please pass in use_reentrant=True or use_reentrant=False explicitly. The default value of use_reentrant will be updated to be False in the future. To maintain current behavior, pass use_reentrant=True. It is recommended that you use use_reentrant=False. Refer to docs for more details on the differences between the two variants. you may need to update to use_reentrant = False as default when grad check

@winglian winglian merged commit 4d2e842 into main Jan 2, 2024
4 checks passed
@winglian winglian deleted the checkpoint-kwargs branch January 2, 2024 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants