Skip to content

Commit

Permalink
fix: warning should not show if eval_batch_size not provided (#896)
Browse files Browse the repository at this point in the history
  • Loading branch information
NanoCode012 committed Nov 25, 2023
1 parent fb12895 commit 7ee3c4c
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion src/axolotl/utils/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,11 @@ def validate_config(cfg):
"batch_size is not recommended. Please use gradient_accumulation_steps instead.",
"To calculate the equivalent gradient_accumulation_steps, divide batch_size / micro_batch_size / number of gpus.",
)
if cfg.eval_batch_size != cfg.micro_batch_size:
if (
cfg.eval_batch_size
and cfg.micro_batch_size
and cfg.eval_batch_size != cfg.micro_batch_size
):
LOG.warning(
"eval_batch_size != micro_batch_size. This can lead to VRAM instability."
)
Expand Down

1 comment on commit 7ee3c4c

@kallewoof
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change was not necessary, if you just swapped the normalize and verify lines, as suggested in #883 (comment)

Please sign in to comment.