Skip to content

Commit

Permalink
drop last from dataloader to help with issues with evals
Browse files Browse the repository at this point in the history
  • Loading branch information
winglian committed Jan 10, 2024
1 parent f4f48e7 commit 4ba82a3
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions src/axolotl/core/trainer_builder.py
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
# pylint: disable=too-many-lines
"""
Builder for the training args and trainer
"""
Expand Down Expand Up @@ -671,6 +672,12 @@ def build(self, total_num_steps):
training_arguments_kwargs[
"dataloader_prefetch_factor"
] = self.cfg.dataloader_prefetch_factor
if self.cfg.dataloader_drop_last is not None:
training_arguments_kwargs[
"dataloader_drop_last"
] = self.cfg.dataloader_drop_last
elif self.cfg.sample_packing and self.cfg.eval_sample_packing is False:
training_arguments_kwargs["dataloader_drop_last"] = True

if self.cfg.val_set_size == 0:
# no eval set, so don't eval
Expand Down

0 comments on commit 4ba82a3

Please sign in to comment.