fix: recently signed check when slashing unavailable validator #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minh-bq
commented
Apr 24, 2023
minh-bq
force-pushed
the
fix/recently-sign
branch
from
62f664d
to
a703c15
Compare
minh-bq
force-pushed
the
fix/recently-sign
branch
from
a703c15
to
7b0e440
Compare
minh-bq
commented
Apr 25, 2023
DNK90
approved these changes
Apr 25, 2023
The first validator in snap.Recents is shifted out and allowed to seal the block already. However, when determining if we should slash the validator we mark that first validator as unable to seal block which is incorrect. This loosens the slash check rule. This commit fix this bug and create a separate helper function to check if the validator recently signed a block.
minh-bq
force-pushed
the
fix/recently-sign
branch
from
7b0e440
to
74c52cd
Compare
andicrypt
pushed a commit
to andicrypt/ronin
that referenced
this pull request
Nov 1, 2023
…nfinity#267) The first validator in snap.Recents is shifted out and allowed to seal the block already. However, when determining if we should slash the validator we mark that first validator as unable to seal block which is incorrect. This loosens the slash check rule. This commit fix this bug and create a separate helper function to check if the validator recently signed a block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first validator in snap.Recents is shifted out and allowed to seal the block already. However, when determining if we should slash the validator we mark that first validator as unable to seal block which is incorrect. This loosens the slash check rule. This commit fix this bug and create a separate helper function to check if the validator recently signed a block.