fix: abort if the private key is different from existed account #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, we automatically create account when no private key is provided and there is not account in keystore. This behavior may lead to mistakes when setting up node, so we remove this behavior in this commit.
minh-bq
force-pushed
the
fix/entrypoint
branch
2 times, most recently
from
a46926d
to
75148ee
Compare
This commit creates a subcommand check in account command of Ronin to check if the corresponding account of provided private key exist in the imported account. When starting Ronin from entrypoint.sh, if the provided private key is different from imported account, the process is aborted.
huyngopt1994
approved these changes
Apr 26, 2023
andicrypt
pushed a commit
to andicrypt/ronin
that referenced
this pull request
Nov 1, 2023
…infinity#265) * fix: don't create account automatically Currently, we automatically create account when no private key is provided and there is not account in keystore. This behavior may lead to mistakes when setting up node, so we remove this behavior in this commit. * fix: abort if the private key is different from existed account This commit creates a subcommand check in account command of Ronin to check if the corresponding account of provided private key exist in the imported account. When starting Ronin from entrypoint.sh, if the provided private key is different from imported account, the process is aborted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we automatically create account when no private key is provided and
there is not account in keystore. This behavior may lead to mistakes when
setting up node, so we remove this behavior in this commit.
This commit creates a subcommand check in account command of Ronin to check if
the corresponding account of provided private key exist in the imported account.
When starting Ronin from entrypoint.sh, if the provided private key is different
from imported account, the process is aborted.