fix: call initContract only when initializing consensus and Authorize #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When profiling node sync with low number of transactions in block, we realize that initContract which unmarshalls JSON innerly consumes around 45% CPU. It is because we call initContract every time we want to call to contract which is redundant and this wastes a lot of CPU. We only need to call initContract when intializing the consensus engine and in Authorize function. Before this commit: + 44.92% 0.00% ronin ronin [.] github.com/ethereum/go-ethereum/consensus/consortium/v2.(*Consortium).initContract + 44.91% 0.00% ronin ronin [.] github.com/ethereum/go-ethereum/consensus/consortium/common.NewContractIntegrator + 44.79% 0.00% ronin ronin [.] github.com/ethereum/go-ethereum/accounts/abi.JSON After this commit: + 43.30% 0.00% ronin ronin [.] github.com/ethereum/go-ethereum/eth/downloader.(*Downloader).spawnSync.func1 + 42.98% 0.00% ronin ronin [.] github.com/ethereum/go-ethereum/eth/downloader.(*Downloader).importBlockResults + 42.98% 0.00% ronin ronin [.] github.com/ethereum/go-ethereum/eth/downloader.(*Downloader).processFullSyncContent
DNK90
approved these changes
Mar 16, 2023
andicrypt
pushed a commit
to andicrypt/ronin
that referenced
this pull request
Nov 1, 2023
…axieinfinity#243) When profiling node sync with low number of transactions in block, we realize that initContract which unmarshalls JSON innerly consumes around 45% CPU. It is because we call initContract every time we want to call to contract which is redundant and this wastes a lot of CPU. We only need to call initContract when intializing the consensus engine and in Authorize function. Before this commit: + 44.92% 0.00% ronin ronin [.] github.com/ethereum/go-ethereum/consensus/consortium/v2.(*Consortium).initContract + 44.91% 0.00% ronin ronin [.] github.com/ethereum/go-ethereum/consensus/consortium/common.NewContractIntegrator + 44.79% 0.00% ronin ronin [.] github.com/ethereum/go-ethereum/accounts/abi.JSON After this commit: + 43.30% 0.00% ronin ronin [.] github.com/ethereum/go-ethereum/eth/downloader.(*Downloader).spawnSync.func1 + 42.98% 0.00% ronin ronin [.] github.com/ethereum/go-ethereum/eth/downloader.(*Downloader).importBlockResults + 42.98% 0.00% ronin ronin [.] github.com/ethereum/go-ethereum/eth/downloader.(*Downloader).processFullSyncContent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When profiling node sync with low number of transactions in block, we realize that initContract which unmarshalls JSON innerly consumes around 45% CPU. It is because we call initContract every time we want to call to contract which is redundant and this wastes a lot of CPU. We only need to call initContract when intializing the consensus engine and in Authorize function.
Before this commit:
After this commit: