feat: impl callTrace2 to support internal tx order #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linh-1
force-pushed
the
feat/impl-calltrace2
branch
from
ffd0082
to
7a947a6
Compare
minh-bq
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The
callTraceis not supporting internal txs' order, so this PR implements a new trace that supportsorder.Orderis the order of the opcode in each tx.Old API response
{ "jsonrpc": "2.0", "id": "1", "result": { "internalTxs": { "0x250559da5e113cc17e5297c5292b2a8a698f273864abdcaf4aace4d889cd8d4f": { "result": { "type": "CALL", "from": "0x968d0cd7343f711216817e617d3f92a23dc91c07", "to": "0x31b070817dbf268bfe1484bd1b4d902c8c4f62df", "value": "0x0", "gas": "0x1325c", "gasUsed": "0xca60", "input": "0xd1e0f3080000000000000000000000008a6e09c0e369086b3ac219ab66f990b0a7d3e1da0000000000000000000000000000000000000000000000000000000000000001", "output": "0x", "calls": [ { "type": "DELEGATECALL", "from": "0x31b070817dbf268bfe1484bd1b4d902c8c4f62df", "to": "0x8a6e09c0e369086b3ac219ab66f990b0a7d3e1da", "gas": "0x1256b", "gasUsed": "0xc1ce", "input": "0x6466414b0000000000000000000000000000000000000000000000000000000000000001", "output": "0x", "calls": [ { "type": "CALL", "from": "0x31b070817dbf268bfe1484bd1b4d902c8c4f62df", "to": "0x359aef78ffa9807889258d0dd398172ca3b77eb1", "value": "0x1", "gas": "0x8fc", "gasUsed": "0x0", "input": "0x", "output": "0x" } ] } ] } } }, "dirtyAccounts": [ { "address": "0xb6bc5bc0410773a3f86b1537ce7495c52e38f88b", "nonce": 0, "balance": "0x5da40dcc1be00", "root": "0x56e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421", "codeHash": "0xc5d2460186f7233c927e7db2dcc703c0e500b653ca82273b7bfad8045d85a470", "blockNumber": 1549, "blockHash": "0xa9c2f5290d405b018c3fe196ff5d34dc17453bc2e6e7688c8dee1ad3e084b2cc", "deleted": false, "suicided": false, "dirtyCode": false }, { "address": "0x968d0cd7343f711216817e617d3f92a23dc91c07", "nonce": 27, "balance": "0x1431e0fad817c0d37148be000", "root": "0x56e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421", "codeHash": "0xc5d2460186f7233c927e7db2dcc703c0e500b653ca82273b7bfad8045d85a470", "blockNumber": 1549, "blockHash": "0xa9c2f5290d405b018c3fe196ff5d34dc17453bc2e6e7688c8dee1ad3e084b2cc", "deleted": false, "suicided": false, "dirtyCode": false }, { "address": "0x31b070817dbf268bfe1484bd1b4d902c8c4f62df", "nonce": 1, "balance": "0xde0b6b3a763ffff", "root": "0x7089744a86585dd4cd821e0e6b9112ee68b2b45466fa8c153f3899b99f9f915d", "codeHash": "0x8925f77045e8209dc19eb826e6fc391b883cd1debd6987577cf5bee434c880c9", "blockNumber": 1549, "blockHash": "0xa9c2f5290d405b018c3fe196ff5d34dc17453bc2e6e7688c8dee1ad3e084b2cc", "deleted": false, "suicided": false, "dirtyCode": false }, { "address": "0x359aef78ffa9807889258d0dd398172ca3b77eb1", "nonce": 0, "balance": "0x2", "root": "0x56e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421", "codeHash": "0xc5d2460186f7233c927e7db2dcc703c0e500b653ca82273b7bfad8045d85a470", "blockNumber": 1549, "blockHash": "0xa9c2f5290d405b018c3fe196ff5d34dc17453bc2e6e7688c8dee1ad3e084b2cc", "deleted": false, "suicided": false, "dirtyCode": false } ] } }New API response
{ "jsonrpc": "2.0", "id": "1", "result": { "internalTxs": { "0x250559da5e113cc17e5297c5292b2a8a698f273864abdcaf4aace4d889cd8d4f": { "result": { "type": "CALL", "order": 0, "from": "0x968d0cd7343f711216817e617d3f92a23dc91c07", "to": "0x31b070817dbf268bfe1484bd1b4d902c8c4f62df", "value": "0x0", "gas": "0x1325c", "gasUsed": "0xca60", "input": "0xd1e0f3080000000000000000000000008a6e09c0e369086b3ac219ab66f990b0a7d3e1da0000000000000000000000000000000000000000000000000000000000000001", "output": "0x", "calls": [ { "type": "DELEGATECALL", "order": 427, "from": "0x31b070817dbf268bfe1484bd1b4d902c8c4f62df", "to": "0x8a6e09c0e369086b3ac219ab66f990b0a7d3e1da", "gas": "0x1256b", "gasUsed": "0xc1ce", "input": "0x6466414b0000000000000000000000000000000000000000000000000000000000000001", "output": "0x", "calls": [ { "type": "CALL", "order": 598, "from": "0x31b070817dbf268bfe1484bd1b4d902c8c4f62df", "to": "0x359aef78ffa9807889258d0dd398172ca3b77eb1", "value": "0x1", "gas": "0x8fc", "gasUsed": "0x0", "input": "0x", "output": "0x" } ] } ] } } }, "dirtyAccounts": [ { "address": "0xb6bc5bc0410773a3f86b1537ce7495c52e38f88b", "nonce": 0, "balance": "0x5da40dcc1be00", "root": "0x56e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421", "codeHash": "0xc5d2460186f7233c927e7db2dcc703c0e500b653ca82273b7bfad8045d85a470", "blockNumber": 1549, "blockHash": "0xa9c2f5290d405b018c3fe196ff5d34dc17453bc2e6e7688c8dee1ad3e084b2cc", "deleted": false, "suicided": false, "dirtyCode": false }, { "address": "0x968d0cd7343f711216817e617d3f92a23dc91c07", "nonce": 27, "balance": "0x1431e0fad817c0d37148be000", "root": "0x56e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421", "codeHash": "0xc5d2460186f7233c927e7db2dcc703c0e500b653ca82273b7bfad8045d85a470", "blockNumber": 1549, "blockHash": "0xa9c2f5290d405b018c3fe196ff5d34dc17453bc2e6e7688c8dee1ad3e084b2cc", "deleted": false, "suicided": false, "dirtyCode": false }, { "address": "0x31b070817dbf268bfe1484bd1b4d902c8c4f62df", "nonce": 1, "balance": "0xde0b6b3a763ffff", "root": "0x7089744a86585dd4cd821e0e6b9112ee68b2b45466fa8c153f3899b99f9f915d", "codeHash": "0x8925f77045e8209dc19eb826e6fc391b883cd1debd6987577cf5bee434c880c9", "blockNumber": 1549, "blockHash": "0xa9c2f5290d405b018c3fe196ff5d34dc17453bc2e6e7688c8dee1ad3e084b2cc", "deleted": false, "suicided": false, "dirtyCode": false }, { "address": "0x359aef78ffa9807889258d0dd398172ca3b77eb1", "nonce": 0, "balance": "0x2", "root": "0x56e81f171bcc55a6ff8345e692c0f86e5b48e01b996cadc001622fb5e363b421", "codeHash": "0xc5d2460186f7233c927e7db2dcc703c0e500b653ca82273b7bfad8045d85a470", "blockNumber": 1549, "blockHash": "0xa9c2f5290d405b018c3fe196ff5d34dc17453bc2e6e7688c8dee1ad3e084b2cc", "deleted": false, "suicided": false, "dirtyCode": false } ] } }