test: fix failed unit tests #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The RemoveOutdatedRecents expects snapshot number which is block number - 1
This test is outdated since the implementation changes. Update the unit test to correctly test the current implementation.
We change toBlockNumArg implementation to transform the block number the same way as RPC: -1 -> latest, -2 -> pending. Update the unit test to reflect the current implementation.
In real system, the bloom of each receipt is calculated before FinalizeAndAssemble block. As a result, we change CreateBloom to MergeBloom when creating block in NewBlock for optimization. However, the GenerateChain function which is used mostly for testing does not follow that assumption. This commit calculates the bloom of each receipt before FinalizeAndAssemble block.
minh-bq
force-pushed
the
fix/unit-test
branch
from
65a3f81
to
68f9860
Compare
huyngopt1994
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.