Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: forbid contract to place bid in RNSAuction #97

Merged
merged 19 commits into from
Oct 24, 2023
Merged

feat: forbid contract to place bid in RNSAuction #97

merged 19 commits into from
Oct 24, 2023

Conversation

TuDo1403
Copy link
Collaborator

Description

This PR forbids contract to place bid in RNSAuction.

Checklist

  • I have clearly commented on all the main functions following the NatSpec Format
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works

Tu Do and others added 19 commits October 12, 2023 15:31
feat: implement Auction contract for RNS (#18)
d030533 
feat: add RNSAuction
@ducthotran2010
Resolve merge conflict/auction (#25)
4492422 
* feat: add Public Resolvers into testnet v0.2.0 (#17)

* forge install: ens-contracts

v0.1

* forge install: buffer

688aa09e9ad241a94609e6af539e65f229912b16

* chore: migrate from private repo

* feat: add PublicResolver & dependency

* fix: outdated name and address in Public Resolver (#5)

fix: outdated name and address in Public Resolver

* fix: resolve merge conflicts

* fix: resolve merge conflicts

---------

Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com>

* feat: add RNSAuction

---------

Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com>
@ducthotran2010
Merge branch 'release-testnet/v0.2.0' into feature/auction
f59b8b8
@TuDo1403
chore: merge 'release-testnet/v0.2.0' into feature/controller (#35)
f257099
@TuDo1403
feat: allow maintain reservation status for ids listed in auction con…
8425f06 
…tract
@TuDo1403
feat: remove setter and event
b09eb66
@TuDo1403
Merge branch 'release-testnet/v0.2.0' into merge/release-testnet/v0.2…
06d9c0b 
….0/feature/auction
@TuDo1403
chore: pull latest from 'release/test-net/v0.2.0' to feature/auction (#…
6ea2558 
…44)
@TuDo1403
Merge branch 'feature/auction' into implement-feature/permanent-tax-f…
a752039 
…or-reserved-id/auction
@TuDo1403
feat: maintain reserved status for ids listed in RNSAuction contract (#…
9ff32b8 
…46)
@TuDo1403
Merge branch 'release-testnet/v0.2.0' into merge/feature/auction/rele…
adbf663 
…ase-testnet/v0.2.0
@TuDo1403
chore: pull lasest features from 'release-testnet/v0.2.0' into featur…
6ad6f52 
…e/auction (#55)
@TuDo1403
Merge branch 'feature/auction' into merge/release/v0.2.0-feature/auction
f3df240
@TuDo1403
chore(auction): merge from release/v0.2.0 (#77)
98c17d9
@TuDo1403
feat: forbid contract bidder
345a490
@TuDo1403
feat: update migration script
b23f0c9
@TuDo1403
format: rename script
d596a17
@TuDo1403
format: rename outdated error
9ecc86f
@TuDo1403
feat(auction): implement eoa-bidder (#96)
5a3867b
@TuDo1403 TuDo1403 changed the title feat: forbid contract place bid in RNSAuction feat: forbid contract to place bid in RNSAuction Oct 24, 2023
@ducthotran2010 ducthotran2010 merged commit f1d8a86 into release/v0.2.0 Oct 24, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ducthotran2010 ducthotran2010 ducthotran2010 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TuDo1403 @ducthotran2010