Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebase/reverse-registrar #12

Closed
wants to merge 25 commits into from
Closed

Rebase/reverse-registrar #12

wants to merge 25 commits into from

Conversation

TuDo1403
Copy link
Collaborator

Description

Checklist

  • I have clearly commented on all the main functions following the NatSpec Format
  • The box that allows repo maintainers to update this PR is checked
  • I tested locally to make sure this feature/fix works

TuDo1403 and others added 25 commits October 4, 2023 21:58
@TuDo1403
feat: add RNSUnified.mint tests
4227444
@TuDo1403
fix: rebase issue
a18fac4
@TuDo1403
feat: add setExpiry tests
e944b8a
@TuDo1403
feat: add overriden ERC721 unit tests
a5c3e1e
@TuDo1403
fix: add bulkSetProtected tests
45d833d
@TuDo1403
feat: add exists check and minor tests update
e048596
@TuDo1403
feat: minor bug fix and more unit tests for setRecord
ab642de
@TuDo1403
feat: resolve issue setRecord owner
2efbb1c
@TuDo1403
feat: add event check
153b255
@TuDo1403
fix: fix revert wrong error code
d2aa24f
@TuDo1403
fix: minor bug fix and refactor tests
0b870a9
@TuDo1403
fix: setRecord expiry
3476223
@TuDo1403
feat: remove arg in error
a3754aa
@TuDo1403
fix: fix test
0c068f9
@TuDo1403
fix: resolve issues
6fcdffc
@TuDo1403
format: add notice comment
874d5ce
@ducthotran2010
Update src/RNSUnified.sol
117bea6 
Co-authored-by: Duke.ron <ducthotran2010@gmail.com>
@ducthotran2010
Update src/RNSUnified.sol
31b42aa 
Co-authored-by: Duke.ron <ducthotran2010@gmail.com>
@ducthotran2010
Update src/RNSUnified.sol
ddeb1e5 
Co-authored-by: Duke.ron <ducthotran2010@gmail.com>
@TuDo1403
format: rename shouldUpdateProtected to shouldRemoveProtected
58a8754
@TuDo1403
override ERC721::_transfer, ERC721::_burn
0f9e10a
@TuDo1403
doc: update comment
fc3c865
@TuDo1403
fix: only remove record.mut
dc150cd
fix: Minor logic and add unit tests for RNSUnified (#6)
0999e7e
@TuDo1403
fix: rebase issue
9a117c8
@ducthotran2010 ducthotran2010 deleted the rebase/reverse-registrar branch October 10, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TuDo1403 @ducthotran2010