Close worker if jobchan is closed #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
DNK90
commented
Nov 23, 2022
DNK90
commented
- Close worker if jobchan is closed
- Also prevent nil pointer if sign method is not defined
|
In current implementation, controller, pool and worker share the same context. When controller and pool is cancelled, worker is cancelled too, so what is the difference in this PR? |
DNK90
force-pushed
the
chore/close_worker_when_jobchan_isClosed
branch
from
d665215
to
e74e4a4
Compare
minh-bq
approved these changes
Nov 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.