Change 'max-duration' to 'maxDuration; #228
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reflects a change made by Sauce Labs to use camelCase instead of hyphen-case. `max-duration` no longer works. This change will still accept the old `max-duration` option, as well as `maxDuration`. If both are specified, `maxDuration` will be used. Suggest possibly deprecating `max-duration` in a future release.
These are not needed for non-hyphenated properties.
Jonahss
reviewed
May 2, 2018
| } | ||
|
|
||
| if (properties.maxDuration) { | ||
| // maxDuration is more consistent with the Sauce Labs capability it maps too |
Jonahss
approved these changes
May 2, 2018
|
@DylanLacey Build is failing. Should we merge this anyways? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reflects a change made by Sauce Labs to use camelCase instead of
hyphen-case.
max-durationno longer works.This change will still accept the old
max-durationoption, as wellas
maxDuration. If both are specified,maxDurationwill be used.Suggest possibly deprecating
max-durationin a future release.Changes include updated documentation.