Allow to configure custom onProgress #194
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a Bitdeli Badge to README
…his when using invalid credentials
Added build param to the docs
Not all ports are proxied by Sauce Connect. Show a warning if port is not in this list: https://saucelabs.com/docs/connect#localhost
Support custom frameworks
the original, suggested snippet will only work on ES5 capable browsers.
Update suggestion for QUnit integration
update reporting code.
Better error message for ECONNRESET
… trace to the logging code. Set the long stack support on q to preserve the async methods' stack trace. Introduced wrapper exceptions when needed to clarify the source of the error.
… problem but this is more general.
…fter ECONNRESET errors, and also logs these errors when the --verbose command line option was specified.
Connection resiliency
Sometimes jobs fail to start, or hang. In these cases, the REST API may
never return 'complete', causing grunt-saucelabs to block 5eva. This PR
adds a maximum limit to the number of checks made against the Sauce Labs
REST API, avoiding this.
Added a config setting, `statusCheckAttempts`, which is an integer
value.
`Job.js` will check whether the REST API returns `complete` a maximum of
`statusCheckAttempts` before throwing an error, reporting:
```
After trying #{statusCheckAttempts} times with a delay of
\\#{pollInterval}s, this job never reached 'complete' status.
```
This means that the job can run for a maximum of `statusCheckAttempts *
pollInterval`.
By default, `statusCheckAttempts` is equal to 90, giving jobs a maximum
runtime of 180 seconds, the current default max runtime after which
Sauce Labs will terminate jobs.
Only check job completion a maximum number of times.
Add 'public' parameter
Output URL and browser when retrying
|
Could you submit your pull request through the master branch? Thanks (I know docs said otherwise, sorry) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This project is really, really helpful. The only thing I would like to change is the comand line output. However, I realize that you may need different output based on context. So I propose two tiny changes that would allow users to create custom progress reporters.
The first change is to allow to configure
TestRunner.onProgress(). The second is to passresultin the jobComplete report. This makes it possible to output more details about the tests.Example: This travis build used this Gruntfile.