Fix token length which now appears to be above 600 #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Change looks good, merging and running through test pipelines. |
|
@ChrisPates thanks! seems to be hitting a go version error? |
|
Yeah, somethings got broken in the workflow. I'll probably have to do work on the CICD pipeline as well. I'm fixing that in the latest release and then I'll attempt to merge the PR again. It appears to be related to go.lang 1.20.x -> 1.23.x change. |
|
No problem, do you have an ETA at all? If it's longer than a few days I'll just deploy it outside of SAM for myself. Thanks! |
|
Hopefully today/tomorrow, I wouldn't bothered with SAM, I would use the official builds in SAR. A lot less hassle. Chris |
|
awesome, thank you! |
|
Okay, the workflows are working, can you update your fork and PR from master, and we can see whether we can merge. |
ChrisPates
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#211
Description of changes:
Adjust SCIMEndpointAccessToken regex to allow more than 600 characters (raised to 620) as a freshly generated token by the AWS console is 603 characters.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.