Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes external dns stack in non-commercial regions #125

Merged
merged 1 commit into from
Oct 28, 2023

Conversation

JoeNorth
Copy link
Contributor

Issue #, if available: #124

Description of changes:

Updates External DNS policyDocument to use Partition variable for Route53 hostedzone ARN instead of assuming aws partition.

Fixes #124

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link
Contributor

@aaroniscode aaroniscode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix!

@aaroniscode aaroniscode merged commit 3e44e4a into awslabs:main Oct 28, 2023
2 checks passed
@JoeNorth JoeNorth deleted the fix-external-dns-policy branch September 18, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

External DNS stack fails in non-commercial regions
2 participants