Configurable RetainCompletenessRule #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeotuan
commented
Apr 19, 2024
| */ | ||
| case class RetainCompletenessRule() extends ConstraintRule[ColumnProfile] { | ||
|
|
||
| case class RetainCompletenessRule(minCompleteness: Double = 0.2, maxCompleteness: Double = 1.0) extends ConstraintRule[ColumnProfile] { |
There was a problem hiding this comment.
Decided not to Parameterize z-value likes in original implementation. Due to the fact that it is related to a specific Interval Calculation Techniques. If possible, we can work into parameterize the strategy use to calculating the interval #563
There was a problem hiding this comment.
Thanks @zeotuan
Can you trim this line to below 120 characters? It is failing checkstyle and failing the build.
There was a problem hiding this comment.
Can we also store the values 0.2 and 1.0 as constants ?
|
@rdsharma26 Hi, Please help review this PR. |
rdsharma26
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #340
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.