Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert codebase to scala 2.13 #499

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

samidalouche
Copy link

Issue #, if available: None, but happy to create one if it helps.

Description of changes:

Is scala 2.13 on your roadmap? Are you considering either providing scala-2.13-only builds, or cross-compiling against 2.12 and 2.13?
If this is something you consider, then I hope this PR will help you.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@@ -81,26 +81,26 @@ class MetricsRepositoryMultipleResultsLoaderTest extends AnyWordSpec with Matche
val analysisResultsAsJson = repository.load()
.getSuccessMetricsAsJson()

val expected =
s"""[{"entity":"Dataset","instance":"*","name":"Size","value":4.0,
val expected =
Copy link
Author

@samidalouche samidalouche Aug 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scala 2.13 collections break the previous ordering of elements

|"instance":"att1,att2","name":"MutualInformation","value":0.5623351446188083},
|{"dataset_date":1507975810,"entity":"Dataset","region":"EU",
|"instance":"*","name":"Size","value":4.0},
|"instance":"att1","name":"MaxLength","value":1.0},
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scala 2.13 collections break the previous ordering of elements

"""[{"entity":"Column","instance":"att1","name":"Completeness","value":1.0},
|{"entity":"Multicolumn","instance":"att1,att2",
|"name":"Uniqueness","value":0.25}]"""
val expectedJson =
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scala 2.13 collections break the previous ordering of elements

|{"entity":"Column","instance":"att1","name":"Histogram.ratio.b","value":0.25}
|]"""
.stripMargin.replaceAll("\n", "")
val expectedJson =
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scala 2.13 collections break the previous ordering of elements

@@ -79,12 +79,13 @@ class VerificationResultTest extends WordSpec with Matchers with SparkContextSpe
val successMetricsResultsJson = VerificationResult.successMetricsAsJson(results)

val expectedJson =
"""[{"entity":"Column","instance":"item","name":"Distinctness","value":1.0},
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scala 2.13 collections break the previous ordering of elements

"""[{"entity":"Column","instance":"att1","name":"Completeness","value":1.0},
|{"entity":"Multicolumn","instance":"att1,att2",
|"name":"Uniqueness","value":0.25}]"""
"""[
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scala 2.13 collections break the previous ordering of elements

@vincenzobaz
Copy link

I am interested in this PR too :)
Is it going to land in main or released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants