Fix builds on clang 16+ #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Note: this issue was originally flagged on freebsd (because it uses clang 16 in ci). so adding free bsd to ci here and also adding newer clangs and gcc's to the test matrix.
Underlying issue is that clang added validation in 16+ to fail on arrays of aligned types.
Switching from having an array of aligned type to aligning whole array to boundary like we do in other places.
Fixes the build and from my testing on C7i.4xlarge, there is no perf difference (or it might be too slow to get lost in the noise).
Not an assembly expert, but on gcc 11 this seems to produce similar assembly
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.