add rollout switches for waiters #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wty-Bryant
approved these changes
Jul 17, 2024
Madrigal
reviewed
Jul 18, 2024
| @@ -58,8 +58,16 @@ public Set<Symbol> getAdditionalClientOptions() { | |||
| return emptySet(); | |||
| } | |||
|
|
|||
| public boolean enabledForService(Model model, ShapeId service) { | |||
There was a problem hiding this comment.
Why do we return true on both waiters? I see that on aws/aws-sdk-go-v2#2717 we use a public member on waiters2 instead of relying on this interface
There was a problem hiding this comment.
The default is true, SDK v2 is extending both of these hooks to be conditional.
There was a problem hiding this comment.
ah, I see, AwsWaiters extends from this class and it defines whether it should use this or not.
Madrigal
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.