-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: disable client side validations #4667
Conversation
// this.fail('EnumError', 'Found string value of ' + value + ', but ' | ||
// + 'expected ' + shape['enum'].join('|') + ' for ' + context); | ||
// } | ||
// } | ||
}, | ||
|
||
validateType: function validateType(value, context, acceptedTypes, type) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this returned bool, what is the effect of returning undefined?
// } else if (this.errors.length === 1) { | ||
// throw this.errors[0]; | ||
// } else { | ||
// return true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this function returned bool
lib/param_validator.js
Outdated
// ); | ||
// } | ||
// } | ||
// return true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the effect of bool to undefined on this?
63f5722
to
8c4ea35
Compare
Removes client-side validators.
Checklist
npm run test
passes.d.ts
file is updatednpm run add-change
bundle exec rake docs:api
and inspectdoc/latest/index.html
if documentation is changednpm run integration
if integration test is changed