chore: disable client side validations #4667
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuhe
reviewed
Aug 14, 2024
| // this.fail('EnumError', 'Found string value of ' + value + ', but ' | ||
| // + 'expected ' + shape['enum'].join('|') + ' for ' + context); | ||
| // } | ||
| // } | ||
| }, | ||
|
|
||
| validateType: function validateType(value, context, acceptedTypes, type) { |
There was a problem hiding this comment.
this returned bool, what is the effect of returning undefined?
kuhe
reviewed
Aug 14, 2024
| // } else if (this.errors.length === 1) { | ||
| // throw this.errors[0]; | ||
| // } else { | ||
| // return true; |
kuhe
reviewed
Aug 14, 2024
lib/param_validator.js
Outdated
| // ); | ||
| // } | ||
| // } | ||
| // return true; |
There was a problem hiding this comment.
what is the effect of bool to undefined on this?
siddsriv
force-pushed
the
rm-client-validators
branch
from
63f5722
to
8c4ea35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes client-side validators.
Checklist
npm run testpasses.d.tsfile is updatednpm run add-changebundle exec rake docs:apiand inspectdoc/latest/index.htmlif documentation is changednpm run integrationif integration test is changed