Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add maintenance mode message #4345

Merged
merged 2 commits into from
Feb 11, 2023

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Feb 10, 2023

Adds a maintenance mode message for 2023.

I still wanted to add a suppression method, but not in the spec-derived config files or as an ENV variable. This suppression method is specific to JSv2, just like the message itself.

Checklist
  • [n/a] npm run test passes
  • [n/a] .d.ts file is updated
  • [n/a] changelog is added, npm run add-change
  • [n/a] run bundle exec rake docs:api and inspect doc/latest/index.html if documentation is changed
  • [n/a] run npm run integration if integration test is changed
  • [n/a] non-code related change (markdown/git settings etc)

@kuhe kuhe requested a review from a team as a code owner February 10, 2023 19:44
@kuhe kuhe merged commit 1477fdb into aws:master Feb 11, 2023
@kuhe kuhe deleted the chore/maintenance-mode-message branch February 11, 2023 19:58
@DavidWells
Copy link

This message is messing with a lot of consuming CLIs. I'd consider reverting this or giving users a way to suppress this message for consumers of their CLIs

serverless/serverless#11753

@kuhe
Copy link
Contributor Author

kuhe commented Feb 17, 2023

There is a suppression method in this PR. I will mention it in serverless/serverless#11753.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants