Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(credential-provider-node): fix tests related to defaultProvider chain #6285

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Jul 16, 2024

  • uses more consistent (with prior functionality) control flow Exception to skip fromEnv in default credential provider chain instead of relying on the provider itself failing

@kuhe kuhe requested a review from a team as a code owner July 16, 2024 21:40
@kuhe
Copy link
Contributor Author

kuhe commented Jul 16, 2024

followup fix for #6277

@kuhe kuhe merged commit 9ca8bae into aws:main Jul 16, 2024
3 of 5 checks passed
@kuhe kuhe deleted the test/credential-provider-node branch July 16, 2024 21:46
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants