Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 'oraclejdk10' to Travis build matrix #572

Closed
wants to merge 3 commits into from

Conversation

sullis
Copy link
Contributor

@sullis sullis commented Jun 24, 2018

Description

add 'oraclejdk10' to Travis build matrix

Motivation and Context

add 'oraclejdk10' to Travis build matrix

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG

License

  • I confirm that this pull request can be released under the Apache 2 license

@sullis
Copy link
Contributor Author

sullis commented Jun 25, 2018

Travis CI build failed.

"java.lang.NoClassDefFoundError: javax/annotation/Generated"

@sullis
Copy link
Contributor Author

sullis commented Jun 25, 2018

similar issue: google/auto#560

@sullis
Copy link
Contributor Author

sullis commented Jun 25, 2018

similar issue: google/dagger#880

@sullis
Copy link
Contributor Author

sullis commented Jun 25, 2018

explanation about the 'Generated' annotation:
https://blog.codefx.org/java/jsr-305-java-9/

@sullis
Copy link
Contributor Author

sullis commented Jun 25, 2018

Oops. ' javax.annotation.processing.Generated' was introduced in JDK 9. It doesn't exist in JDK 8.

@zoewangg
Copy link
Contributor

Thanks for the PR. Instead of adding extra loads on Travis, we have created Codebuild jobs to build with JDK9 and JDK10.

Side note, we fixed the NoClassDefFoundError issue by avoiding using javax.annotation.Generated and using our own @Generated annotation instead. See also #584

@zoewangg zoewangg closed this Jun 28, 2018
aws-sdk-java-automation added a commit that referenced this pull request Jul 30, 2019
…c3cb3d72

Pull request: release <- staging/51aaee0c-a643-48b4-8edd-56a9c3cb3d72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants