-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Six removal v2 #8758
Merged
Merged
Six removal v2 #8758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nateprewitt
force-pushed
the
six_removal_v2
branch
from
July 2, 2024 23:21
e36f324
to
93720ba
Compare
nateprewitt
force-pushed
the
six_removal_v2
branch
2 times, most recently
from
July 3, 2024 01:00
18473f1
to
c86e77a
Compare
nateprewitt
force-pushed
the
six_removal_v2
branch
from
July 3, 2024 16:22
c86e77a
to
d11f815
Compare
hssyoo
reviewed
Jul 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for this PR. Just had a couple questions on added imports
hssyoo
approved these changes
Jul 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🏆
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #8754 to start moving the six removals into the CLI v2. This should be an almost identical patch from v1 with some minor additions to botocore and net-new CLI code in v2.
Currently in draft, this should encompass all usages of six and bring the files in the CLI v2 inline with botocore/s3transfer to minimize conflicts with future merges.