Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Six removal v2 #8758

Merged
merged 6 commits into from
Jul 8, 2024
Merged

Six removal v2 #8758

merged 6 commits into from
Jul 8, 2024

Conversation

nateprewitt
Copy link
Member

Follow up to #8754 to start moving the six removals into the CLI v2. This should be an almost identical patch from v1 with some minor additions to botocore and net-new CLI code in v2.

Currently in draft, this should encompass all usages of six and bring the files in the CLI v2 inline with botocore/s3transfer to minimize conflicts with future merges.

@nateprewitt nateprewitt force-pushed the six_removal_v2 branch 2 times, most recently from 18473f1 to c86e77a Compare July 3, 2024 01:00
@nateprewitt nateprewitt marked this pull request as ready for review July 3, 2024 18:18
@nateprewitt nateprewitt requested review from hssyoo and kdaily July 3, 2024 18:18
Copy link
Contributor

@hssyoo hssyoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for this PR. Just had a couple questions on added imports

tests/functional/docs/test_help_output.py Outdated Show resolved Hide resolved
tests/functional/s3/test_cp_command.py Outdated Show resolved Hide resolved
Copy link
Contributor

@hssyoo hssyoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏆

@nateprewitt nateprewitt merged commit 6cd533a into aws:v2 Jul 8, 2024
36 checks passed
@nateprewitt nateprewitt deleted the six_removal_v2 branch July 8, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants