sync: document --delete behavior for excluded files #4937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #4937 +/- ##
========================================
Coverage 93.95% 93.95%
========================================
Files 189 189
Lines 14524 14524
========================================
Hits 13646 13646
Misses 878 878
Continue to review full report at Codecov.
|
Running `aws s3 sync --delete ...` will not delete files that are
excluded by filters. For example:
```bash
aws s3 mb s3://sync-delete-exclude
mkdir /tmp/sync-delete-exclude
touch /tmp/sync-delete-exclude/{1,2,3,4}
aws s3 sync /tmp/sync-delete-exclude s3://sync-delete-exclude
# no files will be deleted:
aws s3 sync s3://sync-delete-exclude /tmp/sync-delete-exclude \
--exclude=3 --exclude=4 --delete --dryrun
```
This is not immediately obvious from the documentation provided, and the
interaction between exclusion filters and the `--delete` strategy flag
should be explicitly stated.
kyleknap
force-pushed
the
doc-sync-delete
branch
from
aaeb634
to
cadaca9
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4937 +/- ##
=======================================
Coverage 0.08% 0.08%
=======================================
Files 208 208
Lines 16627 16627
=======================================
Hits 14 14
Misses 16613 16613
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
aws s3 sync --delete ...will not delete files that areexcluded by filters. For example:
aws s3 mb s3://sync-delete-exclude mkdir /tmp/sync-delete-exclude touch /tmp/sync-delete-exclude/{1,2,3,4} aws s3 sync /tmp/sync-delete-exclude s3://sync-delete-exclude # no files will be deleted: aws s3 sync s3://sync-delete-exclude /tmp/sync-delete-exclude \ --exclude=3 --exclude=4 --delete --dryrunThis is not immediately obvious from the documentation provided, and the
interaction between exclusion filters and the
--deletestrategy flagshould be explicitly stated.
solves the documentation issue with #4923.