feat(autoscaling): add new HealthChecks for multiple health check types, including EBS and VPC_LATTICE types
#31286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
go-to-k
changed the title
HealthChecks instead of old HealthCheck
github-actions
bot
added
p2
distinguished-contributor
go-to-k
changed the title
HealthChecks instead of old HealthCheckHealthChecks for multiple health check types, including EBS and VPC_LATTICE types
go-to-k
commented
Sep 2, 2024
Comment on lines
+2355
to
+2371
| /** | ||
| * Additional Health Check Type | ||
| */ | ||
| export enum AdditionalHealthCheckType { | ||
| /** | ||
| * ELB Health Check | ||
| */ | ||
| ELB = 'ELB', | ||
| /** | ||
| * EBS Health Check | ||
| */ | ||
| EBS = 'EBS', | ||
| /** | ||
| * VPC LATTICE Health Check | ||
| */ | ||
| VPC_LATTICE = 'VPC_LATTICE', | ||
| } |
There was a problem hiding this comment.
EC2 had to be excluded because specifying EC2 and other types together would result in a CFn error.
Resource handler returned message: "Specifying EC2 in addition to other health check types is not supported. Remove EC2 from HealthCheckType and try again. (Service: AutoScaling, Status Code: 400, Request ID: ...
| * @default Duration.seconds(0) | ||
| * @see https://docs.aws.amazon.com/autoscaling/ec2/userguide/health-check-grace-period.html | ||
| */ | ||
| readonly grace?: Duration; |
There was a problem hiding this comment.
The grace has to be specified in the existing ELB options, but this is not necessary now. (I actually deployed the configuration without the grace successfully).
aws-cdk-automation
added
the
pr/needs-community-review
github-actions
bot
added
the
feature-request
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #31289 .
Reason for this change
Only ONE HealthCheckType can be selected for an existing healthCheck property: EC2 or ELB.
https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/aws-autoscaling/lib/auto-scaling-group.ts#L233
https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/aws-autoscaling/lib/auto-scaling-group.ts#L2232-L2258
However, the current CFn specification allows multiple health check types to be specified, separated by commas.
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-autoscaling-autoscalinggroup.html#cfn-autoscaling-autoscalinggroup-healthchecktype
Also, besides EC2 and ELB, EBS and VPC_LATTICE can now be configured.
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-autoscaling-autoscalinggroup.html#cfn-autoscaling-autoscalinggroup-healthchecktype
If it was just EC2 and ELB, there would not be a need for multiple specifications. (Because specifying EC2 and another type at the same time would result in a CFn error. This means that when specifying an ELB, it is a single specification.)
But the increase in the number of these property types makes multiple specifications necessary. Therefore, it is good to support the specification of multiple health check types and the addition of new types at the same time.
See the docs for more details.
https://docs.aws.amazon.com/autoscaling/ec2/userguide/ec2-auto-scaling-health-checks.html
Description of changes
So, I add a new
HealthChecksclass andhealthChecksproperty.And I deprecated the existing
healthCheckproperty.Description of how you validated changes
Unit and integ tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license