chore: add option unacknowledged to cdk notices #31250
Conversation
github-actions
bot
added
effort/small
awslukeguan
requested a deployment
to
test-pipeline
GitHub Actions
Waiting
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
aws-cdk-automation
added
the
pr/needs-cli-test-run
packages/@aws-cdk-testing/cli-integ/tests/cli-integ-tests/cli.integtest.ts
Outdated
Show resolved
Hide resolved
| const version = await fixture.cdk(['version'], { verbose: false }); | ||
| const noticesUnread = await fixture.cdk(['notices', '--unread'], { verbose: false }); | ||
| // regex greaterThan 2.154.1 but not including 3.x.x | ||
| const regexVersionGreaterThan = /^2\.(154\.[2-9]|154\.1\d{1,}|15[5-9]{1}\.|1[6-9].{1,}|[2-9]\d{2}\.)/; |
There was a problem hiding this comment.
This sort of regex is ripe for bugs. It's long and there's no way I'm checking its validity.
Why are we making this test version-specific? It shouldn't be, if you need special notices data, the CLI test should mock the needed calls.
There was a problem hiding this comment.
Drop the -only maybe? Seems redundant.
There was a problem hiding this comment.
@mrgrain thoughts on naming? Should it be --unacknowledged or --unread, or something else?
awslukeguan
changed the title
awslukeguan
changed the title
awslukeguan
requested a deployment
to
test-pipeline
GitHub Actions
Waiting
awslukeguan
requested a deployment
to
test-pipeline
GitHub Actions
Waiting
awslukeguan
requested a deployment
to
test-pipeline
GitHub Actions
Waiting
awslukeguan
requested a deployment
to
test-pipeline
GitHub Actions
Waiting
awslukeguan
requested a deployment
to
test-pipeline
GitHub Actions
Waiting
awslukeguan
requested a deployment
to
test-pipeline
GitHub Actions
Waiting
awslukeguan
requested a deployment
to
test-pipeline
GitHub Actions
Waiting
awslukeguan
temporarily deployed
to
test-pipeline
GitHub Actions
Inactive
|
➡️ PR build request submitted to A maintainer must now check the pipeline and add the |
comcalvi
added
pr-linter/cli-integ-tested
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #23078
Reason for this change
cdk noticeswill show all the notices the cdk version is affected by.The additional command
cdk notices --unacknowledgedwill show the notices the customer hasn't acknowledge withcdk acknowledge <NUMBER>.The output will display the number of unacknowledged notices, with the following line as the last statement:
There are <NUMBER> unacknowledged notice(s).Customer or automation tools can use this command to filter for the number of unacknowledged notices.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license