Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(vpcv2): adding rosetta for ReadMe #31191

Merged
merged 2 commits into from
Aug 23, 2024
Merged

Conversation

shikha372
Copy link
Contributor

@shikha372 shikha372 commented Aug 23, 2024

Issue # (if applicable)

Closes #.

Reason for this change

Adding rosetta lib to populate documentation for VPCv2.

Description of changes

Adding rosetta lib to populate documentation for VPCv2.

Description of how you validated changes

Validated that readMe has no failures with below command
yarn rosetta:extract

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Aug 23, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team August 23, 2024 00:34
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 23, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@shikha372 shikha372 changed the title chore(vpcv2): Adding rosetta for ReadMe chore(vpcv2): adding rosetta for ReadMe Aug 23, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review August 23, 2024 00:38

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@shikha372 shikha372 marked this pull request as ready for review August 23, 2024 00:40
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Aug 23, 2024
Copy link
Contributor

mergify bot commented Aug 23, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Aug 23, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: fd64bf3
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit e3351a4 into aws:main Aug 23, 2024
12 checks passed
Copy link
Contributor

mergify bot commented Aug 23, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2024
@shikha372 shikha372 deleted the vpcv2_readme branch September 4, 2024 17:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants